dbadia
dbadia
Does 90ade64 provide full JWE support, or is this still a work in progress? Any estimate for a release with JWE support?
@lhazlewood Understood, thanks for the quick reply
Sorry, I should have mentioned this replaces #12895. I have addressed almost all of comments from the old PR. The old PR had mention of "fixing the markdown table" in...
Made some updates per your recommendations. Enjoy your beer and your new year's eve
OK, wasn't sure if I should still be rebasing since I merge some of the commits you made... turns out I should be, thanks for the reference article. Did the...
Also, is it normal the PR build to be failing? Errors out with `Could not find the selected project in the reactor: :org.openhab.addons.reactor.features.karaf`
Ah, thanks. Made that update and confirmed I am in CODEOWNERS. Seeing some errors and warnings about my code in the build now, I'll work on fixing those next
Ok, build is passing and I think I've fixed everything. Let me know if you need anything else from me
Oh sorry, I totally missed the new comments - I'll have a look! Appreciate your patience and help as this is my first time working on a new binding
> Thanks for addressing most isseus and clarifying others. While looking at it i found these. There are some small things i like to investigate a little further, allmost ready...