daw538
daw538
Thanks Stephen for the feedback -- think I've manged to address and integrate everything you've suggested into the new version.
Yes, the change to `idealised_moist_phys.F90` was made to fix the issue where the trip tests would fail at the buckets module for any trip test where moist processes were involved,...
Good start, I've added just a little extra here and there. I guess there could be a good amount of discussion about what order we'd tend to prioritise the various...
Before this is completely addressed, is it worth checking if the fix applied in #236 needs applying to the other environment files? I think it only has been done to...
Yes, it's definitely going to need some consideration. The type error listed above wasn't the only one that @sit23 and I had to change in order to get the code...
I've now updated this to include changes associated with the cloud scheme in #246
Broadly looks fine to me. Most of the code is adding functionality rather than editing the existing model so happy to okay if it works as intended. Probably don't need...
Overall happy with this. Many of the changes I'm already familiar with on my own fork since we've worked on some of this together before as you mention. The bits...