davidd-lunarg

Results 8 comments of davidd-lunarg

Looks good, but it needs clang format before it can be merged.

> is this app a good candidate for testing out https://github.com/LunarG/gfxreconstruct/pull/1138 ? Yes, this may be a good app to test with #1138. If the VR app is not using...

> CI gfxreconstruct build # 4762 failed. This is failing because it is finding the wrong `dxcompiler.dll`. GFXR may need to redistribute that file from the Windows SDK, I will...

> We've mostly avoided having to build binaries for other projects from the source as part of our build The AGS GitHub repo includes the binaries at https://github.com/GPUOpen-LibrariesAndSDKs/AGS_SDK/tree/master/ags_lib/lib so GFXR...

A base/derived class hierarchy for the file processor classes would be more natural for me. Is that feasible? What trade offs are there compare to the template approach?

The use case for this proposed change is to: 1. Give users the ability to limit log file size, especially in automated environments where GFXR isn't directly monitored by a...

> Ideally, it would be great to be able to pass global indices for every required field in dump resources. This is how the Vulkan feature for dump-resources works--see [vulkan_dump_resources.md](https://github.com/LunarG/gfxreconstruct/blob/dev/vulkan_dump_resources.md)....

I am seeing this happen during recapture when `vkBindBufferMemory` is used to repeatedly bind temporary buffers to a persistently mapped `VkDeviceMemory`. Sometimes but not always when the buffer is bound,...