David

Results 10 comments of David

Hey @AJax2012, I'd recommend not removing `mb-3` and adding another prop like `noMargin` as UIs would change if anyone updates to the later reactstrap with this change.

> Is it possible to mock `Transition` for just two tests and leave it as is for the remaining tests? The rest of the tests will pass if you remove...

> @davidacevedo Thanks a lot. I had tried that but was missing `const { Alert } = require('..');` Now the test is passing. Why is it that we have to...

Seems like this needs some rebasing

Seems like there are some tests failing

`form-group` won't be added back in as it doesn't exist anymore in the bootstrap context, but what about having a prop that disables the default margin class?

I'll try testing this a bit more later to see if I can validate my assuptions. It does look good otherwise

So, this is a good next step, but we should also include `[warning, info]` as those other colors also require `text-dark` https://getbootstrap.com/docs/5.1/components/badge/#background-colors

We can't completely get rid of commonjs yet as testing frameworks like jest still don't support esm outside of an experiment. Commons is usually needed for the node side of...

Tbh, I don't really understand the issue above. Is this in the webpack context, node context, or something else? Can this possibly be a configuration error? I tried require('reactstrap') in...