David Liu

Results 11 comments of David Liu

@DanielNoord wow, thank you! So sorry for the delay, I think I saw your message and meant to reply months ago but then... forgot. My bad! Your question is a...

> Let me know what you think of my changes. I made the tests pass on 3.7 and made some of the typing a little more strict. I appreciate that...

@DanielNoord Okay I reviewed all of your changes, they look good to me! Yeah I was going for more general types but happy to stay strict for now and expand...

Yikes, I'm sorry I totally missed the last review from months ago! 😞 I'm happy to make all the requested changes later today, shouldn't take long.

Sorry for the commit spam, I'm currently only running 3.10 locally. If this continues I'll fix it properly...

Thanks for the review @cdce8p! I'll make these updates in the next couple of days for sure.

Hello! I apologize for the delay again in making these updates (just have had a lot of other things going on). Notably, I've moved the constraint code back into a...

Thanks @DanielNoord and @cdce8p! I wasn't sure exactly when I'd have time to look at this again so very much appreciate the updates. 👍 BTW on the question of whether...

💯 @Pierre-Sassoulas thank you! And thank you all for the efforts in reviewing this and keeping the branch up to date. I'm super excited to see how this evolves!

Hi @jacobtylerwalls! Sorry I'm in the middle of exam season so I don't have a lot of time, but off the top of my head it looks like: 1. The...