david-cortes-intel comments

Results 204 comments of


                                            david-cortes-intel

[enh] Conda recipe update and CI OS version pinning

Question: are the commands in `meta.yaml` for executing tests actually needed if it will end up calling the `run_test.sh/bat` scripts in the end? E.g. do they execute somewhere else too?

[enh] Conda recipe update and CI OS version pinning

> @Alexsandruss This was merged with an error in the WindowsCondaEnv Python3.12_Sklearn1.5 step The error appears to be sporadic though.

TEST: Produce JSON logs from pytest runs

> @david-cortes-intel I'll review when we get CI's green Fixed the windows issues - all CI jobs are passing now.

TEST: Produce JSON logs from pytest runs

Made some changes to only add the argument `--json-report-file` when receiving argument `--json-report`, in response to @icfaust 's comment about the argument resulting in an error instead of being ignored...

TEST: Produce JSON logs from pytest runs

/intelci: run

TEST: Produce JSON logs from pytest runs

> I see mention of presence of json-report package in public CI logs but beyond that is there a way to validate this is running as intended? Modified it to...

TEST: Produce JSON logs from pytest runs

/intelci: run

TEST: Produce JSON logs from pytest runs

/intelci: run

TEST: Produce JSON logs from pytest runs

/intelci: run

Memory leak using RandomForestClassifier and PCA

Problem appears to have been fixed with this PR: https://github.com/uxlfoundation/scikit-learn-intelex/pull/2540 The fix should be available in version 2025.7 once it gets released.