David Burg
> I managed to get the model from the new method Request.GetModel(). Thanks I don't understand this comment. Request.GetModel() (and SetModel) methods were made obsolete long ago and replaced with...
> * You cannot use string interpolation as we still support target framework that require us to use an old(er) C# compiler. SSH .NET targets Framework 3.5 as the oldest,...
> * I don't see why our diagnostics class should be public. You can register listeners without this. Because the trace source Listeners needs to be accessible to enable programmatically...
> I also don't like these "magic" event ids. Perhaps consider using an internal enum for this? Yes "magic" event ids are not ideal. I agree that an enum is...
@drieseng could you take a new look at this?
@drieseng ping for review / next step
@drieseng I noticed you are active today. Could you review the answers here?
> I left some remarks in my latest review. > The most important remarks are: > > 1. Revert usage of string interpolation in order to keep support for older...
https://github.com/user-attachments/assets/ecf54df3-de47-4a44-a9af-934930b54bcb Adding short video recording of unresponsive UX, still happening with current version and affecting all the actions displaying the SAP RFC list.
@tonytang-microsoft-com maybe an issue you can look into?