David Brito

Results 27 comments of David Brito

It's also worth to note that this is someway a breaking change because old links wont work with this.

I think this is an expected limitation of the current implementation. There will always be this problem unless we use some backend to store the code instead of the URL...

Hello @Carreau I could fix this. In the way I did it at https://github.com/ipython/ipython/pull/12650

I am having problem passing [this test](https://github.com/ipython/ipython/blob/3c2c1857268fba1833b324d8b4e4ce53b0220b83/IPython/core/tests/test_paths.py#L57), and others similar. > ```python > def test_get_ipython_dir_2(): > """test_get_ipython_dir_2, Testcase to see if we can call get_ipython_dir without Exceptions.""" > with patch_get_home_dir('someplace'),...

@Carreau this pull request is ready for review

> There seem to be a number of commented test with TODO and the rebasing went wrong, I'll try to fix some of this. I talked about those tests at...

This would be great to have on `servor`. @lukejacksonn is possible to merge this?

Hi. It seems that this has been around for a while. What's the current status of this?

I'm having the same issue since the update to the latest version

> I already fixed this in #1917. We just have to wait for a release of react-pdf which includes this. When will this be released? I think it's critical.