Damien Arrachequesne

Results 711 comments of Damien Arrachequesne

Yes, I think it should be handled by the `debug` dependency directly. Please see https://github.com/visionmedia/debug/issues/589.

The documentation was updated: https://socket.io/docs/v3/client-installation/ Basically: - `socket.io-client/dist/socket.io.dev.js` => `socket.io-client/dist/socket.io.js` - `socket.io-client/dist/socket.io.slim.js` => `socket.io-client/dist/socket.io.min.js`

It seems it's possible: https://stackoverflow.com/a/56364967

Could you please provide a way to reproduce? (I tried with jest with no luck: https://github.com/darrachequesne/jest/commits/test/socket.io)

Hi! The trailing slash is added there: https://github.com/socketio/engine.io-client/blob/dfee8ded722a8c4f9f773505d0c77b4561569863/lib/socket.ts#L335 (initial commit from 2012: https://github.com/socketio/engine.io-client/commit/93605fd3e950d68130900e37ce0beeceef8eea5c) I guess we could add an option to include it or not. Could you please explain your...

That's an interesting idea! I guess we could also reset it for outgoing packets too, so the timeouts are kept more or less in sync. What do you think?

Thanks, I could indeed reproduce. Since we cannot have two (or more) active Socket instances for the same namespace and the same Manager, the most reasonable behavior would be to...

@georgeedwards `Module parse failed` seems to be webpack (version 1.x, if I'm not mistaken) failing to read the sourcemap file (which is served by the server by default). I think...

You are right, this is indeed a side effect of https://github.com/socketio/socket.io-client/commit/16b65698aed766e1e645c78847f2e91bfc5b6f56 (rationale [here](https://github.com/socketio/engine.io-client/commit/00d7e7d7ee85b4cfa6f9f547203cc692083ac61c)). I'm open to suggestions on how to elegantly fix this.

That sounds weird indeed. Were you able to debug the issue?