Ben Howard
Ben Howard
@Promaethius what's the status on this PR? Do you want to update this, or should we close it out?
> I'm +1 as long as we don't mess with the current interface to do it.... I think that's roughly what you're describing... @ajeddeloh you are correct, I don't want...
Adding an interface would likely result in more OO code and I'm not sure there is a demand for it.
/assign darkmuggle Thanks @dustymabe I'll get on that :)
@dusty I suspect that this is related to the hard-coding patch of `aarch64` that you wired in. When I tested locally using main and #2186 I don't see this happening.
> If that is the case, I would like to argue that being able to build coreos-assembler from scratch with podman for different architectures allows users to embed the container...
Removing the `USER builder` would work just fine for the RHCOS pipelines, however, they need the user defined. Otherwise :+1:
@bh7cw Are you interest in tackling this? The effort for this is low and the high value. I think the best approach would be to do a single PR for...
Roughly this shows we have the following issues: ``` 50 (errcheck) 29 (staticcheck) 24 (gosimple) 12 (deadcode) 7 (unused) 7 (ineffassign) 7 (govet) 2 (structcheck) ```
> /hold Checking: > `14:42:03 time="2021-05-11T17:42:03Z" level=fatal msg="failed to define builder pod: failed setting in-cluster options: pods \"pod-9f110ac1-fc9c-438f-ad93-a5a7589b7020-b6pd3-lfmj6\" is forbidden: User \"system:serviceaccount:coreos-ci:default\" cannot get resource \"pods\" in API group \"\"...