Darin Adler

Results 22 comments of Darin Adler

After fixing this bug we need to update quite a few expectations in `LayoutTests/TestExpectations` to expect success!

We may want to accomplish the same thing by changing all the callers!

It looks like there are about 100 callers. We could do them in small batches. I agree that doing by directory makes the most sense. Might want to figure out...

We will need A/B performance tests on this patch. Replacing all the many `Color` objects, 64-bit scalars, with slightly larger objects and adding some checks and overhead could have an...

> or should I just be preferring bugzilla 'order' when resolving duplicates? Really not important. Just make sure we have a single bug in each database and the other is...

Maybe we should save some memory by using atom strings instead.

It’s important to include a test. It’s required unless you explain in the pull request why you can’t. If you say we won’t be running the test on bots for...

> Is there a mechanism to invalidate the cache when the IDL changes? No. But it’s an in-memory cache during the runtime of the script, not an on-disk cache.

`paramterNameFromString` has a misspelled word in it