dantrongamz

Results 5 comments of dantrongamz

iOS Native Module Crash: Optional Methods in Spec Not Properly Generated

Update reproducible repo with ReactNative version 0.79.2, I still see the same issue. Please remove the label "Type: Unsupported version"

iOS Native Module Crash: Optional Methods in Spec Not Properly Generated

Added a fix in https://github.com/facebook/react-native/pull/51632

Runtime crash due to asynchronous Promise resolution in Android/Kotlin classes

Thanks @mrousavy . I have tried with the latest code from main branch in a new PR https://github.com/mrousavy/nitro/pull/673 When click on running the test in example app "Async Promise resolution...

Runtime crash due to asynchronous Promise resolution in Android/Kotlin classes

FYI, I attempted to update the de-constructor logic of JPromise.hpp in https://github.com/mrousavy/nitro/commit/84580e6630e0a9c13f3a780ce34ea0fd6016a7f3 but it doesn't fix this issue yet.

Runtime crash due to asynchronous Promise resolution in Android/Kotlin classes

Thanks a bunch for this tricky fix! Our team has been eagerly waiting!