Dan Pascu comments

Repositories
Issues
Comments

Results 3 comments of


                                            Dan Pascu

NSMapArg type definition is incorrect.

According to this comment: ```py # See https://github.com/python/typing/pull/273 # Due to Mapping having invariant key types, Mapping[Union[A, B], ...] # would fail to validate against either Mapping[A, ...] or Mapping[B,...

Variable assigned in branches of an if statement is considered as being redefined

Doesn't look like it to me. That issue is about allowing redefinition when using `--allow-redefinition` when the lifetimes don't overlap. This issue is about inferring the variable as the union...

gh-123720: When closing an asyncio server, stop the handlers

I think this fix is incomplete. I believe the `__aexit__` method of `AbstractServer` at https://github.com/python/cpython/blob/ef06508f8ef1d2943b2fb1e310ab115b65e489a8/Lib/asyncio/events.py#L253-L255 also needs to be modified to include a call to `self.close_clients()`.