Daniel Poggenpohl

Results 106 comments of Daniel Poggenpohl

The pull request looks fine to me (but I have only looked at it fleetingly). I'd really appreciate for it to be merged, you don't know how often I clicked...

Also in the second migration script... An index is created even if it already exists... (This seems to be not a migration, but an initial installation code)

Maybe this would fix the problem? https://github.com/h5p/moodle-mod_hvp/pull/412

The problem now is there doesn't seem to be a way to check if mod_hvp has a localisation for a specific code. Or am I missing something?

Okay, we recently switched from the local langpack "de_some" to storing the customlang version of the language packs "de_local" and "en_local" which makes this change unnecessary for us. So feel...

Hi, we're currently experiencing the race condition problem and tested the pull request code of https://github.com/catalyst/moodle-mod_hvp/pull/23 which fixes the issue. What can I do to help getting this approved?