prr
prr copied to clipboard
danobi
Mailing list style code reviews for github
This will mostly help people that uses more than one account in github and constantly switch tokens, today I'm being forced to maintain it manually like the following: ```toml [prr]...
Instead of reviewing the sum of all changes, I'd like to review commits one-by-one. Unfortunately, the github API doesn't make this easy. I have a [hacky script](https://github.com/krobelus/gitlab-offline-review/blob/a6fc06706d3ef94f8726331f559c0b9379c5728d/gl.py#L1367-L1406) that tries to...
I've started VS Code extension over here: https://github.com/matklad/code-prr I grow it for private consumption and have no intention maintaining it, but perhaps it could serve as a starting point for...
https://github.com/danobi/prr/commit/0889e77dc18e23b9aaac889aae1d36522b50a9cb regressed dirty checks. I think we want to bring back `status_opts.include_ignored(false);`. Regression (with some debug info): ``` $ git status On branch master Your branch is up to date...
Right now we pass around strings and string references everywhere. It mostly works, except in a few places it's ambiguous whether or not text is quoted or unquoted text that...
👋🏻 firstly, thank you very much for making prr available for others to enjoy, excellent tooling! --- Currently prr expects a short path format of `//`, e.g., `prr get danobi/prr/24`,...
I went to try out this tool on Windows and it fails to compile `xdg` (naturally). I understand if not supporting Windows is intentional, however if not, it should be...
From: https://github.com/danobi/prr/pull/40#pullrequestreview-1782484039 Couple of nice-to-have things: * That's highly controversial opinion, but I personally prefer cargo fmt to be triggered by cargo test, rather than by my CI, so that...
If I write a review, submit it, and then go update the review file, a new submit will create comments all over again. Ideally I would be able to update...
