prr icon indicating copy to clipboard operation
prr copied to clipboard

feat: Update comments on review re-submit

Open tekknolagi opened this issue 2 years ago • 4 comments

If I write a review, submit it, and then go update the review file, a new submit will create comments all over again. Ideally I would be able to update the existing comments in place.

tekknolagi avatar Dec 11 '23 22:12 tekknolagi

In-place edit sounds a bit complicated to implement. There's probably quite a bit of state to keep track of to accomplish this. It would also conflict with the ability to add multiple comments in the same place (in two separate submits). On a higher level, it's not quite mailing list like. For example, once you send an email you cannot really take it back and edit it.

On the other hand, I could be convinced idempotency would be worthwhile to add. So that you duplicates don't get uploaded.

danobi avatar Dec 12 '23 03:12 danobi

If no edits (fine), then it might make sense to:

  • Delete PR text once submitted (or at least rename it)
  • Provide a way to render the whole thread in mailing list format
  • Provide a way to transform edits to the full thread into new comments

tekknolagi avatar Dec 12 '23 05:12 tekknolagi

Also, to be clear, I do not need this feature or tool for anything critical! I only discovered it today and it seems neat and like something I would use, and I tried to submit a feature issue like the others already in the repo. I am not trying to ask for a bunch of work for free.

tekknolagi avatar Dec 12 '23 05:12 tekknolagi

No worries, all feedback is welcome!

danobi avatar Dec 12 '23 15:12 danobi