Daniel Parks
Daniel Parks
Would you be opposed to adding the boolean attributes to the list that are accepted without a value? I imagine they all could be treated as true, but I would...
Ok! I added some docs to help clarify what the difference is. I suppose we could call it `wait_optional_timeout()` instead of `poll()` too?
Sure, I‘m definitely in favor of clarity. I actually noticed that exact issue in some other code just the other day. Would you like me to prepare a PR?
Ah, I see. I’m not using sockets, I’m using pipes from a child process. Perhaps I should look into adding a method to `std::process`… Otherwise, those both seem like good...
Ok, PR #6 submitted!
Here's an even simpler case: ~~~ ❯ echo -n nonl | od -c 0000000 n o n l 0000004 ❯ echo -n nonl | eyaml decrypt --stdin | od -c...
A simpler example: ~~~ ❯ eyaml encrypt -s nonl -o string | tr -d '\n' | eyaml decrypt --stdin | od -c 0000000 n o n l \n 0000005 ~~~
Really low priority. I just noticed it while looking at the code. I'll handle it if you just want one that uses a regex whenever the first and last characters...
I'm not sure this is relevant, but if the default logger outputs something like JSON, then it should actually output JSON. Currently it's just a string that values are inserted...
Unfortunately [valgrind-macos](https://github.com/LouisBrunner/valgrind-macos) seems to give results that are all over the place. Each run returns different numbers, whereas in a Docker container it seems to always return the same numbers...