Daniel Fone comments

Results 7 comments of


                                            Daniel Fone

after_commit fires even when a transaction is rolled back

If this is not the desired behaviour, I'm happy to explore a PR. Without looking too hard, I think it'd need to tie into ActiveRecord's callbacks rather than [fire its...

Validate path params defined on the path item

@ota42y ahh good catch! I'm not likely to be able to look at this for a week or so. If I get to it before you I'm happy to have...

Validate path params defined on the path item

@ota42y I haven't added any specs for this yet, I wanted to see what you thought of the implementation. I've opted to merge the individual hashes explicitly in the `OpenAPIParser::Schemas::Operation`...

Validate path params defined on the path item

@ota42y thanks for the feedback. I'll add some specs and ping you for a final review.

Timeline in Status Message

Hi @rjocoleman! 😁 I like this idea I think. I originally imagined it would be used somewhat synchronously, but perhaps it would be useful if you were waiting for longer...

Pundit caching isn't sensitive to current user changing

Thanks @Burgestrand. Yes, I don't blame you if you don't want to support this use-case, I should really implement it as a high-order concern. In my specific case, the other...

make #headers public on CsvBuilder

> should I break out tests for #headers or Good question. I think since it's now part of the public interface it's worth having a few basic tests against it....