Daniel Flower

Results 51 comments of Daniel Flower

Hi Marcel, sorry I know it's frustrating to not get feedback. I just really don't have much time to go through things very often. Merging a pull request is a...

The reason I've not merged this so far is that in my mind this is a fundamental change to the plugin. In my mind, the plugin generates build numbers for...

Hi, I don't know if you are still interested in this, so long afterwards, but if you want to get it merged I think all it's missing is an explanation...

Yeah, I guess I never understood this PR then. So if I have `1.0-SNAPSHOT` and set build number to `BETA` it becomes `1.0.0-BETA`. The next release (with no custom build...

Hi, I think "dry run" is a bit misleading because it all this doesn't do is push the tags, right? A user may have a deploy step which would still...

So it seems like this is another tag option? Maybe `pushTags` should be deprecated and a new property called `tagAction` or something with values `NoTags`, `Create` and `CreateAndPush` (the default).

Yeah, this is a reasonable feature to have. How about something like a config option called `` or something? README.md docs/whatever.txt Could be expanded to be regex or in `.gitignore`...

Hi there. I've never really used Git sub-modules so I don't really understand what would be required to get it working, or what the high level rules would be. How...

I still don't have personal experience with sub-modules, so I probably won't work on this myself. But if anyone has the time, then it wouldn't be too hard to add...