Danny Dudzic

Results 15 comments of Danny Dudzic

Thank you for reporting. I'll mark this as: Duplicate of #1909

Since the author hasn't responded in 2 weeks, I'm closing this issue, but please feel free to re-open/create a new issue with further details.

![dashboard](https://user-images.githubusercontent.com/905781/37174327-762eede0-2316-11e8-9666-65dbbc646678.png) ![ms0fy5gyxm](https://user-images.githubusercontent.com/905781/37172579-86c630a0-2311-11e8-964b-0ccc3129c326.png) @jeffikus I was able to replicate using Browser Stack, on both Mac and Windows with any Firefox 56+ version I tried.

@allancole After some further investigation, it seems that this issue is prevalent across most (if not all) of our themes (with dropdowns expanding to the right). I think it would...

Safari: * Desktop: Focus stops on the last navigation item before the Search icon * Mobile: Focus gets correctly trapped for both Navigation and Search Firefox: * Desktop: Focus gets...

@Aljullu Re: > I also noticed the stars are not visible in the Site Editor I have just noticed the same issue occurs for the All Products block. Would you...

> Thanks for applying the changes and updating this PR, @danieldudzic! > > > I have just noticed the same issue occurs for the All Products block. Would you mind...

> I noticed that some elements get a numeric id (ie: `id="5"`). I think that's problematic because ids need to be unique in the page and it's easy to introduce...

> In recent PRs, we added [loading skeletons](https://github.com/woocommerce/woocommerce-blocks/pull/6990) to filter blocks. We will need to do the same for the Products by Rating block. @danieldudzic can you create an issue...

> Besides that, I noticed that the placeholder title is strangely big compared to the other filter blocks Thank you for the review! I'm not seeing the issue with the...