Daniel Blando

Results 21 comments of Daniel Blando

@damnever Do you have any use case or example of this happening? The only think I could think is maybe concurrence issue, because we do have a check on these...

Why do we need new limits for nativeHistogram? Isnt histogram already counted to the ingestionRante https://github.com/cortexproject/cortex/blob/844fa558726ca4a621b1265cc20b8f557d552da8/pkg/distributor/distributor.go#L775

>NH samples are much more expensive that float samples. Float sample is always 8 bytes. A NH sample with 160 buckets and 160 spans will be ~2.5 KB in size....

We are in the process of releasing 1.18 Please rebase PR and change the changelog to master

Sorry for the HUGE late review. Thanks a lot for the work. Overall lgtm, just the header count i am worried about. We can discuss of having as approximation if...

Hey @MichaHoffmann, I am not sure I understood your question. More on my use case. We use Thanos as library on Cortex. The shipper runs in our ingester (thanos receiver)....

Agree, the `querier.query-store-after=0` is bad for performance and in some cases for missing data depending on the `-querier.query-ingesters-within`. Correct, the idea is to have ingesters on READONLY mode and you...

>what should happen if -distributor.extend-writes is enabled? do we keep writing to the readonly ingester? That would be confusing 🤔 [friedrichg](https://github.com/friedrichg) For the `extended-write`, this would not change much. The...

@friedrichg If we dont extended in write for readonly, the scale down doesnt work. Because normally after this step we filter the subRing to check if we have enough ingesters...