Daniel Nichter
Daniel Nichter
This should be/might be handled by [Time.Equal](https://golang.org/pkg/time/#Time.Equal)? If the things being compared have an `Equal` method, it's used: ``` // Types with an Equal() method, like time.Time, only if struct...
Sorry for slow reply. I'm not sure how to handle this. `Time.Equal()` is authoritative for itself, so I don't think we should mess with that. I'm surprised Go isn't zeroing...
Thanks, I see the issue and I agree: if one wants 1000 ns == 1234 ns to be true, then sure. But I'll have to poke at the code to...
Sorry for slow reply. No significant reason that I can recall. To see how it works out, can you submit a PR? To maintain backward-compatibility, it might need to be...
Can you give an example of what you'd like to see for both? Order shouldn't matter for maps, but it's inherent to slices.
Hello 👋 Thanks for the PR and fixes. I'd like to include this work, but the blocker is the changes to the test suite. Given the complexity of this pkg,...
It's a good idea and would make a good change for v1.1. There's a couple things I'd change wrt the design, etc. 1. `s/MakeComparer/New Comparer/` as "NewX" is more idiomatic...
Thanks for the bug report. I'll see if/how to generalize the test for an `Equal` method to cover all such cases.
Hi @shlomi-noach :-) I think "resurrect" is not the best term. It's not a standard technical term. Even doc/command-line-flags.md has to clarify: "It is possible to resurrect/resume a failed migration"....
Same here, I think this should be documented or changed. Having `onMessage` update scope vars but not `onClose` was confusing until I found this issue.