Daniel Beck
Daniel Beck
Previously: https://github.com/jenkinsci/jenkins/pull/4670
This seems to work well. I especially like that on applicable views, the search field gets focused. That was always annoying. Nobody can navigate Available or even Installed without that....
FTR I responded in Gitter.
Interactive testing of this PR is a jarring experience. I don't know whether it is just because it's different from before, or whether moving the links into the sidepanel is...
> I didn't manage to get any suggestions in firefox even by doing some searches and installing some plugins This PR moves the search field outside of the form, so...
> Can you clarify what is holding back the approval please? Available time and competing priorities. I like to review and test nontrivial changes in depth. What I wrote above...
Would be interesting to know why this space was added in the first place. @janfaracik do you remember its purpose? MY guess is content like UpstreamBuildCause and model-link HyperLinkNotes in...
It is unclear to me whether the issues referenced by @NotMyFault are still applying, but the current state modifies too many links. Comparing the current weekly and the PR build's...
The new version looks fairly similar to how the normal Jenkins UI does field validation, while at the same time being quite different (above the field vs. below, same line...
> See https://weekly.ci.jenkins.io/design-library/Validation/ how it should be done Ah, good point. That makes sense. Still, the differences with how form validation otherwise works are awkward.