Hai Hoang Dang

icon company Meta icon location USA

Results 11 comments of Hai Hoang Dang

README links don't work in PyPI.

@goswami-rahul yeah I will loot at it when I have the chance

Update flake8 style checking and tox

I signed it!

Error: get error in testing

yeah `python3 setup.py test` works for me

Make configuration validation function return error message

could you elaborate your idea? I see you check function `tlog_*_conf_validate` with return value `grc`. I am not sure about using `assertion` in here.

Make configuration validation function return error message

I am little bit confused. the function `tlog_*_conf_validate` is used to check validation of configuration. It does not modify, or produce configuration. So I do not need to add `assert`...

Unify init/cleanup and create/destroy function presence

I check unify init/cleanup and create/destroy function presence. I see there are some miss `cleanup` functions in 3 files. Miss tlog_json_dispatcher_cleanup in file json_dispatcher.c: https://github.com/Scribery/tlog/blob/master/lib/tlog/json_dispatcher.c Miss tlog_mem_json_writer_cleanup in file mem_json_writer.c:...

Make configuration validation function return validation error message

I have updated it

Implement error handling macros

Hi Nick, could you write some example about error-handling patterns are repeated in code?

Implement error handling macros

Hi Nick, before doing that, do you want to add line, function, file ( the same debug output) into stack err? It is convenient because when you have many error...

Implement error handling macros

Hi Nick, I see there are 4 different types repeated. Should I write 4 function in Header to handle them? `1. pushf` `2. pushs` `3. pushc, then pushf ` `...