Daniel Burckhardt comments

Results 16 comments of


                                            Daniel Burckhardt

Implement EIP191 signing handler on Ethermint

Comment from @fedekunze: > We'd need to define the use cases and scope of work for this. Would we need to fork the SDK like osmosis did?

Eip712 doesn't support `any` messages

@ramirocarlucho Lets try to avoid forking the sdk

Create Event Router for EVM tx post processing

@facs95 we moved it back to Todo, since there is no draft PR yet. Is there any work done here already?

`--gas=auto` flag is confusing because it doesn't take min gas price into account

I'm generally experiencing weird behaviour with setting the --gas flag: It seems like transactions up to around --gas=124000 gas fail, even though there gasLimit for normal transactions is much lower...

Migrate JSON-RPC to OpenRPC

seems that an old, uncompleted version is already supported: https://github.com/etclabscore/ethereum-json-rpc-specification [ethereum-json-rpc-specification.org/](http://ethereum-json-rpc-specification.org/) https://etclabscore.github.io/core-geth/JSON-RPC-API

Migrate JSON-RPC to OpenRPC

https://github.com/tharsis/evm-json-rpc-spec

Rename feesplit to revenue

There are some occurrences of `feeSplit` that were missing, let me push some missing replacements

imp(erc20): support registering multiple assets

@fedekunze I separated the test suite refactor into [this ticket](https://linear.app/evmos/issue/ENG-939/refactor-common-test-suite-setup-into-a-clear-test-util)

Add command to generate eip712 type data for msg

> > @yihuang can you add a PR description about what users can do with this? > > done. sorry I didn't follow up closely on this PR, because we...

fix: skip codehash check when the code has been deleted in the evm state

@yihuang isn't the test with empty code hash still missing? ``` emptyCodeHash := crypto.Keccak256(nil) codeHash := common.BytesToHash(emptyCodeHash).String() ```