Daniel Belcher

Results 10 comments of Daniel Belcher

It's not clear now what should happen in Standard mode for values that used to only be displayable with scientific notation. For example, in Standard mode, if I input `100,000,000...

Arcadio, this is great! We are still in the process of transitioning into the open, so I don't think anyone was expecting contributions so soon. Adding ink support into Calculator...

The engine is C code compiled with a C++ compiler. We've been making updates over time to improve the safety and practices of the codebase. For this issue, the goal...

`ref new` should stay for now. In CX, these are ["hat" pointers](https://docs.microsoft.com/en-us/cpp/cppcx/ref-classes-and-structs-c-cx?view=vs-2017#memory-management); essentially, they are smart pointer types. `zmalloc` can be removed. Here is an instance of naked new that...

Yep, a blank app for the unit tests is intentional. The UTs cover classes like the ViewModels which can only be instantiated in a UWP app.

In the PR, I mentioned that we wanted to eliminate PRAT entirely, thereby solving this issue because there would be no manual allocations of RAT structs. So, perhaps we can...

They likely can be replaced with calls to `make_unique`. For example: ```C++ PRAT tmp; createrat(tmp); ``` can become: ```C++ auto tmp = make_unique(); ```

Yes, memory is leaking because `delete[]` was not called on the data member. As discussed in [#211](https://github.com/Microsoft/calculator/pull/211#issuecomment-480371366), using arrays this way is non-standard behavior and we should change the member...

Yeah, `delete[]` was a bad suggestion on my part. The memory isn't dynamically allocated.

Stack-allocation seems like the best choice here so it's likely that change will be brought in to master. We get better performance and memory safety. I said earlier that this...