danaimset

Results 11 comments of danaimset

Preconditions: 1. I have a bunch of requests. 2. The next one debounce(disposes) the previous one. 3. I have OkHttpInterceptor installed to check if my access_token is expired or about...

Seems there is also missing XML attribute for BottomNavigationView: badgeStyle or badgeResource(xml) So there will be chance to customize badge in BottomNavigationView

> Hi @danaimset could you please explain why you want to "allow drawable background" on a BadgeDrawable, which is itself a drawable. Hi @wcshi ! It's mostly about badge customization...

![badge](https://user-images.githubusercontent.com/2340784/71067737-20550b00-2186-11ea-872c-82d3b005ac45.png)

I absolutely agree with you about badge text. I suppose that measurements should be resolved on BadgeDrawable side. In my case it is badge on BottomNavigationView's icon

That's especially noticeable on devices with small width. Without stroke it looks ugly. Of course it looks better if badge has color different from icon but it is meaningless restriction...

I tried to draw custom badge where I'd like to use drawable background. https://drive.google.com/file/d/1Hfw7eSmzw6bJWIyz505CtGG_6OyTj6N5/view?usp=sharing

According to comment #1200 this issue is going to be closed. What about custom badges I've drawn in my previous comment? (where each is a combination of shapes actually) Am...

> @danaimset did you mean to link to a different issue? The issue #1200 is still open and there's no mention of this issue. > > Right now custom badge...

Same step 8: - Remove userComponent from logout() function and replace it with a call to `userDataRepository.initData(username)`. There should be `cleanUp` instead. Meanwhile it's correct in a code snippet