Damian Ho
Damian Ho
Seems easy enough to implement ```diff diff --git a/app/models/user.rb b/app/models/user.rb index 48af212e..b265f0c0 100755 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -17,7 +17,9 @@ class User < ApplicationRecord has_one :github_integration trim_field :school -...
Perhaps add `config.x.autograder.default_autograde_image = ""` to `config/environment/.rb` and change `autograders_controller.rb#create` to use `a.autograde_image = Rails.configuration.x.autograder.default_autograde_image`
Could probably be done with a mixture of `help-blocks`, `pattern` attribute (e.g. `.{8,}`), and using the [hashes](https://stackoverflow.com/questions/53088609/how-to-show-devise-error-messages-one-by-one) to display corresponding errors for each field.
Feature seems pretty broken, might be worth a rewrite with newer libraries
Change required should be `Zip::Entry.new(zos, "#{File.basename(filepath)}", nil, nil, nil, nil, nil, nil, ctimestamp)` --> `Zip::Entry.new(zos, "#{File.basename(filepath)}", time: ctimestamp)`
The "exam in progress" option in course settings seems to handle this?
Also not caught on import from file system. But this can only occur if a user that has an assessment with invalid config directly navigates to the edit assessment page...
If we aren't too concerned with generating an error page, the following patch would probably suffice: ```Diff diff --git a/app/controllers/assessments_controller.rb b/app/controllers/assessments_controller.rb index 8988bba0..96ba0c9f 100755 --- a/app/controllers/assessments_controller.rb +++ b/app/controllers/assessments_controller.rb @@ -145,7...
If we really wanted to handle import from file system too, one option is something like ```ruby def importAssessment @assessment = @course.assessments.new(name: params[:assessment_name]) begin @assessment.load_config_file # only call this on...
I am unable to reproduce the issue, if possible could you attach any logs?