Damian Hamill

Results 25 comments of Damian Hamill

@andrewc910 @eliasjpr yes I think the plugin approach is the best way to add features like GraphQL support to Amber projects. PR #1197 makes minimal changes to existing code other...

@crimson-knight the relevant file **lib/amber/src/amber/controller/helpers/responders.cr** hasn't been updated in 2 years so I am sure the issue still exists without needing to test it.

IMHO this is correct behaviour as environment variables should always take precedence over static configuration. Setting the env variable AMBER_ENV=test will use the test database URL in the amber test...

what we should probably do is have an extra test service in the docker-compose file that sets the AMBER_ENV variable to test and the DATABASE_URL variable to the test db...

> @damianham would you know how to resolve this issue? Fixed in PR #1135

At the moment the recipes generator does not re-implement the Auth generator. However if we add a plugin type generator to recipes then anything could be generated. Also we could...

@drujensen OK great, when I get some free time I will make a start on this.

My current thoughts on the implementation of a plugins feature; Plugins should be pieces of code that you drop into an Amber app that adds features to your app, much...

We could also have a plugin sub-command to generate plugins from a plugin recipe, e.g. ``` amber plugin generate PLUGIN_URI ``` which would work along the same lines as the...

I don't disagree that there is an advantage of adding a plugin as a shard to bring in the dependencies but as you point out Dru you cannot include the...