Drew Kersnar
Drew Kersnar
This seems like a safe early exit to me, but I'm curious how common this case is to warrant the added complexity of the early exit code. Are there real-world...
Looking into this now
In the code, what's happening is we are adding `positionIndex` to our result here https://source.dot.net/#System.Memory/System/Buffers/ReadOnlySequence.cs,580, which is equivalent to `seq.Start.GetInteger()` which returns `1`. This index is relative to the *array*...
@NinoFloris After some discussion I think 2.a. is correct here. If you would like to put up a fix (with a unit test preferably), feel free, otherwise I can tackle...
Haven't had time to follow up on this yet. I just wanted to add a small update that I'm no longer confident this is a bug. When I tried to...
Improvements https://github.com/dotnet/perf-autofiling-issues/issues/8818#issuecomment-1266628997 (and other improvements throughout the issue. We are filing all improvements and regressions from a single commit range in a single issue now, hence why this is so...
After running this by @luisquintanilla, nothing immediately stands out to us about why your source code might be causing this error. Can you tell us a little bit more about...
That does seem like a typo. @luisquintanilla where would this need to be updated?
cc @luisquintanilla
Is this blocked by something specific, or should we rerun these skipped tests?