David Faust

`IdentifierExpr`s are our hack, and it would be good to remove eventually in favor of just using Path expressions. https://github.com/Rust-GCC/gccrs/blob/eca2ac2c23e0c8b438fd696d4f85e35c9210d8dd/gcc/rust/hir/tree/rust-hir.h#L370-L374 https://github.com/Rust-GCC/gccrs/blob/eca2ac2c23e0c8b438fd696d4f85e35c9210d8dd/gcc/rust/parse/rust-parse-impl.h#L12525-L12533 According to [the reference](https://doc.rust-lang.org/reference/expressions/path-expr.html), references to local variables etc....

https://github.com/Rust-GCC/gccrs/blob/e43a5c5373b341d217d2f5403f31f5174b8c4e2f/gcc/rust/rust-gcc.cc#L1699-L1702 > Can we make an issue to pull this out into rust-tree.h at some point it would be nice to eventually get rid of this abstraction since you have...

LiteralPatterns lose their minus prefix

2

(Note: this came up while testing #1244, below case will not compile without support for integer primitives in match, but it is a general problem.) I tried this code: ```rust...

Parser ICE on syntax error in match arm block

1

I tried this code: ```rust enum E { One, Two, Other } fn foo (x: E) -> i32 { let mut y = 0; match x { E::One => {...

Enforce file contents are valid UTF-8 in include_str! macro

1

Strings and strs are always valid UTF-8 in Rust. We should enforce that in the `include_str!` builtin macro. https://github.com/Rust-GCC/gccrs/blob/0fa882160df40cee56b5cdd0a2953b4abb4b9d18/gcc/rust/expand/rust-macro-builtins.cc#L232-L233

RFC: arrange tuple matches in trees not HIR

1

Opening this as draft because I'm not sure whether it is the best path forward, and I'd like to see if anyone has thoughts one way or another. This commit...

This is a brain dump of the various bits of match expressions that we aren't currently compiling. Probably incomplete. Patterns https://doc.rust-lang.org/reference/patterns.html - [x] Literal Patterns `1`, `'a'` - [ ]...