Deepak Mishra comments

Results 26 comments of


                                            Deepak Mishra

Unable to access query params in case of POST request

This is still open and a major issue @ancode4

getOutputStream() has already been called for this response

https://stackoverflow.com/questions/3540464/java-lang-illegalstateexception-getoutputstream-has-already-been-called-for-t

POST request fails made by 'xrequest'

#121 should fix this as well. We will be using JSON Object instead of flattening.

XRequest Error Response JSON Format

@ancode4 can this issue be closed then?

Avoid false positive vulnerability for file upload location

This issue is still reported by sonarqube. https://sonarcloud.io/component_measures?id=metamug_mason&metric=security_rating&selected=metamug_mason%3Asrc%2Fmain%2Fjava%2Fcom%2Fmetamug%2Fmason%2Fservice%2FUploaderService.java&view=list

Information exposure through a stack trace

@kaisteel is this fixed? What else needs to be done for this issue

Internal Resource call

JSP forward can be used instead of xrequest. to do this. https://kodejava.org/how-do-i-forward-request-to-another-page-in-jsp/

Added @WebFilter annotation for Router

Hope you tested that the config can be overwritten using web.xml since developers may want to keep the rest api elsewhere On Sat, 14 Dec 2019 at 11:18 AM, Kaustubh...

Debug Tags. Logger with debug flag

The tags have to log, their input and output values when debug flag is on. This will help detect errors.

Mason not initializing without context.xml

RequestProcessable interface requests a DataSource. so not providing a datasource isn't an option currently. Or else the datasource object should be assigned null in case context.xml isn't provided