Daniel Siepmann

Results 14 comments of Daniel Siepmann

Well the issue is not having different extensions with same name, but in general you can't change the extensions between tests within the same class. Our concrete use case: We...

I guess this was now done by transforming the existing unit tests into functional tests via https://github.com/TYPO3BestPractices/tea/issues/1569

I'll close this PR in favour of the smaller split up PRs where the initial feedback is incorporated.

Fine for me. But I guess the target is not to use `runTest.sh` as another layer/wrapper, but instead of the composer task. So get rid of the composer script and...

It might be easier to just rework the code and not initialize TSFE but directly fetch the TypoScript whenever possible, e.g. in frontend context.

This is triggered here: https://github.com/TYPO3-Solr/ext-solr/blob/main/Classes/Controller/AbstractBaseController.php#L103 Stacktrace: ``` [0] ApacheSolrForTypo3\Solr\System\Configuration\ConfigurationManager->getCoreTypoScriptFrontendByRequest @ vendor/apache-solr-for-typo3/solr/Classes/System/Configuration/ConfigurationManager.php:121 [1] ApacheSolrForTypo3\Solr\System\Configuration\ConfigurationManager->getTypoScriptFromRequest @ vendor/apache-solr-for-typo3/solr/Classes/System/Configuration/ConfigurationManager.php:69 [2] ApacheSolrForTypo3\Solr\Controller\AbstractBaseController->initializeAction @ vendor/apache-solr-for-typo3/solr/Classes/Controller/AbstractBaseController.php:103 [3] ApacheSolrForTypo3\Solr\Controller\SearchController->initializeAction @ vendor/apache-solr-for-typo3/solr/Classes/Controller/SearchController.php:45 ``` I've added this, which works for...

The same issue occurs when indexing pages via the Queue Backend module. For the same reason, no Variables are passed to properly evaluate the TypoScript conditions. `FrontendTypoScriptFactory->prepareConditionMatcherVariables()` can be used...

Thanks @dkd-kaehm that helped. Also in other contexts where I just encountered the same issue, e.g. backend modules and indexing. I don't have any error entries any more. Thanks for...

Thanks @fsuter for the fast response. You understand correctly. I'll try to come up with a PR, but can't make any promise on the timing yet. Yeah, it is quite...

@fsuter I could come up with a PR already. I hope it matches your expectations. I ran phpstan, cs fixer and tests locally. I propose to continue within the PR....