Paulo Alvarado

[META] Menus cleanup

1

**To Do** - [ ] Move menus app into cms app. - [ ] Refactor cache invalidation. - [ ] Add site awareness to menu rendering. - [ ] Multiple...

Include a note in plugin docs about ordering

1

We should mention in the custom plugin docs that overriding plugin ordering is not possible. Related #5001

Static placeholders don't track dirty status for each language

8

If a user adds content to a static placeholder in multiple languages, publishing one of these languages will cause the dirty flag of the static placeholder to be set to...

Remove old code

1

So I was going to commit a fix for https://github.com/stefanfoulis/django-filer/blob/develop/filer/models/foldermodels.py#L20 but looks like this method is not even used or working. It throws a `FieldError` because the field `has_all_mandatory_data` does...

Articles can be recovered with Aldryn Reversion but the tags do not come back.

Context does not persist when rendering plugins

4

Some plugins rely on context variables set by their parent's `render()` method, because of how plugins are rendered here, the context is always new instead of being shared by plugins,...

This error happens because here https://github.com/divio/django-emailit/blob/develop/emailit/api.py#L71 you pass a nested list instead of a normal list.

Allow escaping of excel formulas

4

Hello, Packages that leverage this app like django-tablib allows us to export user submitted data. This exposes a potential security issue where users can add excel formulas to certain exported...

Don't render app placeholders as editable

2

Using the {% placeholder %} tag outside of cms pages has been forbidden for some time but currently the cms still renders these placeholders as editable even though they don't...

Accessing request.body throws error

2

`cms.middleware.toolbar.ToolbarMiddleware` accesses request.POST on every request, causing django to process the data and prevent us from accessing the `request.body`. ``` ipdb> request.body *** RawPostDataException: You cannot access body after reading...