Chengyou Liu

Results 37 comments of Chengyou Liu

> For Lightning via SQL we should have already required the SUPER privilege. > > For TiDB backend, there is no security flaw as the RBAC system should be able...

Maybe we need to define our security boundary to be on the same page

And it might take too much time to get error for missing one of the permissions when users importing large data with tidb backend. It's not effecient.

It seems we have an issue to plan to achieve part of this on the tikv side https://github.com/tikv/tikv/issues/8621

This might be a really significant issue when it comes to more than 20k tables. It will show 100% for hours. Users will never understand what's going on here.

It didn't happen again while retrying last time. So it's not 100% users might hit.

/label severity/minor

According to @3pointer, it's a boundary issue that br restore cannot handle properly with an auto_random table runs out auto_random_base. BR overflows with this table. This particular table is from...

@kennytm One of the tables is like this ```sql CREATE TABLE PK_AUTO_RANDOM9112 (COL1 BIGINT AUTO_RANDOM,COL2 VARCHAR(20),COL4 DATETIME,COL3 BIGINT,COL5 FLOAT,PRIMARY KEY(COL1)) ; insert into PK_AUTO_RANDOM9112 (COL1,COL2,COL4,COL3,COL5) values(9223372036854775807,"褡蛗漜挰疔嗶降镑頫猔嬕兪袱哖節砭批酨焷詧","0892\-05\-21\ 19:03:19",-685882192225613411,-7.625264136427621e+37); ```

According to [What should I do when BR restores data to the upstream cluster of TiCDC/Drainer?](https://docs.pingcap.com/tidb/stable/backup-and-restore-faq#what-should-i-do-when-br-restores-data-to-the-upstream-cluster-of-ticdcdrainer), operations like is not supported yet.