cygaar
cygaar
@Amxx are you referring to one of the github workflows?
Super convenient, looks like the gas went down for all the 1155 tests. For some reason ERC20VotesMock gas went up, but I'm guessing this might be some sort of transient...
I hear you, but my arguments for adding in this change are: 1) I don't think anything should be breaking per se - calldata is allowed in internal function calls....
Can you elaborate more on `it changes the execution context.`?
Great to see, thanks for updating!
Yeah @wwhchung is correct here - it's extremely easy to game `owner()` to make it look like someone else deployed your contract
we're currently in the process of refactoring how plugins are setup and initiated so we'll probably hold off on merging this for now
I'll fix shortly!
@cvauclair I'm pretty sure the logic I have here works - I added a log to check if the index was created and it seems to work. I checked the...
ah cool, i'll look into that