Cyclinder
Cyclinder
I'm sorry for not replying for a long time, I've been busy with work these days..
> Could you extend `Documentation/concepts/networking/masquerading.rst` to show how to use the new way of configuring the ipmasq? Sure! Hi @brb , I'm not a english speaker, so If you could...
> The proposal looks reasonable to me. Should we rework the `ipMasqAgent` test in `test/k8s/datapath_configuration.go` to use this mechanism, so that we can test that the helm configuration works correctly?...
Thanks @joestringer ,I am now fixing it. Does this PR need some kind of label like `/kind feature` or something? I found that I set it, but it didn't work...
> Minor nit. Thanks for the job 👍！ I will add these to the PR based on your suggestions，Is complete this `TODO` in another PR? I can take this one,...
> The TODO needs to be done in this PR if you decide to change the tests. Otherwise, the tests will fail. Ok, I still prefer to make this change...
> It seems to me like 90% of the test changes are already done in the diff above, the configuration just needs to be removed. Is that more than just...
> helpers.CiliumNamespace Okay, Thanks.
Thanks @kaworu @sayboras ，Hi @joestringer ， Now this PR can be merge？
> @cyclinder Thanks. Could you rebase your code against the latest Cilium's master. It should fix some GH action failures. Once it's done, I will rerun the CI. Thanks @brb...