Craig Perkins

Results 453 comments of Craig Perkins

> @cwperks I moved this PR to target `feature/identity` where we have more flexiblity @peternied Its hard to see the changes this PR is introducing now. Would it be possible...

@peternied Any idea what's going on with the CI check here? I see `BUILD SUCCESSFUL in 22m 14s` in jenkins, but this is saying UNSTABLE.

I see 2 test failures: ``` Tests with failures: - org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation - org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections ``` Are these known flaky tests?

@nibix Thank you for the detailed RFC, I agree with a lot of the comments left here on memory and wondering if there are optimizations that can be made on...

[Triage] Thank you for filing the issue @RyanL1997 . Are the selenium tests for SAML still running on the windows runner?

[Triage] Thank you for filing @peternied. Having performance tests in general for optimizations will help measure the benefit of PRs that provide optimizations w/o any end user change.

This change needs to go into 2.x first to resolve the bwc test failures. 2.x isn't compiling along with main since this change was recently backported to 2.x in core.

Thank you for the contribution @dancristiancecoi! The changes look good to me.

Created a backport for this change to 2.x. Once that's merged the bwc checks can be re-run on this PR: https://github.com/opensearch-project/security/pull/4319

Thank you @willyborankin ! Looks like the bwc checks are green now. Merging this PR.