Carl Pearson

examples/fig12_save_figure.nim does not automatically close the webview

6

``` Nim Compiler Version 0.20.2 [MacOSX: amd64] Compiled at 2019-07-17 Copyright (c) 2006-2019 by Andreas Rumpf git hash: 88a0edba4b1a3d535b54336fd589746add54e937 active boot switches: -d:release ``` Running ```nim c -r -d:webview --threads:on...

saveImage with `.png` filename causes assertion failure

5

``` Nim Compiler Version 0.20.2 [MacOSX: amd64] Compiled at 2019-07-17 Copyright (c) 2006-2019 by Andreas Rumpf git hash: 88a0edba4b1a3d535b54336fd589746add54e937 active boot switches: -d:release ``` Modifying examples/fig12_save_figure.nim to save a file...

Reduce idle warps for small blocks in BsrMatrix-multivector tensor core product

153

Use only one fragment per team when the matrix block size is small enough.

Improve parallelism in building CUDA sparse and batched GEMM tests

222

A revision of #1330. Using CUDA backend as an example (this is applied to all backends) Break the monolithic `unit_test/cuda/Test_Cuda_Sparse.cpp` into multiple translation units, in this case * `unit_test/cuda/Test_Cuda_Sparse.cpp` includes...

utils: implicit copy-assign deprecated in array_sum_reduce

3

c++11 deprecated implicit copy-assign operators when a copy-constructor is defined. array_sum_reduce is actually okay with implicit versions both copy-ctor and copy-assign, so don't define either one ourselves

c++17: add [[fallthrough]] attribute

75

Now that we require c++17 support, use [[fallthrough]] to suppress `-Wimplicit-fallthrough` and friends

The destination of this deep copy is the raw argument pointer (an input argument), when instead it should probably be the `values` member of the BlockCrsMatrix class: https://github.com/kokkos/kokkos-kernels/blob/564dccb339d8d1528c2bb948abdac0c6e48e09d5/src/sparse/KokkosSparse_BlockCrsMatrix.hpp#L929 Furthermore, the...

Remove Experimental::BlockCrsMatrix (replaced with Experimental::BsrMatrix)

10

This PR removes `Experimental::BlockCrsMatrix` and everything that references it. The replacement is intended to be `Experimental::BsrMatrix`, which matches its interface and has a data layout consistent with third-party library (TPL)...

https://github.com/kokkos/kokkos-kernels/blob/6e0ea104d724dd5f8b25d7d1d9cd539a18af7be0/perf_test/sparse/KokkosSparse_sptrsv.cpp#L308-L309 https://github.com/kokkos/kokkos-kernels/blob/6e0ea104d724dd5f8b25d7d1d9cd539a18af7be0/perf_test/sparse/KokkosSparse_sptrsv.cpp#L710-L711 https://github.com/kokkos/kokkos-kernels/blob/6e0ea104d724dd5f8b25d7d1d9cd539a18af7be0/src/graph/impl/KokkosGraph_Distance2Color_impl.hpp#L188-L193 Now that c++17 is required, `[[fallthrough]]` may help silence some warnings and mark a fallthrough as intended

Poor parallelism when building tests

1

Building tests in Kokkos Kernels exhibits low parallelism when the CUDA and OpenMP spaces are enabled. Consider two different ETI configurations: "small" ``` float, double layoutLeft, layoutRight offset size_t ordinal...