Magamedrasul Ibragimov
Magamedrasul Ibragimov
Then wouldn't it be better to use `as u8` or `as usize` everywhere and get rid off this impl's ?
@DreamWuGit Yes, If you already work on this it's alright, thanks for letting me know
It's not directly related to `MCOPY`, but I'm working on this, and looking through `RETURNDATACOPY`, which we discussed before @ChihChengLiang It is said, that `RETURNDATACOPY` copies from memory to memory:...
Thanks a lot. Yes, we should update after the fix:)
> Hey @mhchia , would one need to recompile/ redeploy all Verifier contracts due to this bug or is it further down the line? @themandalore In general I would say...
@ssjeon-p As you see `cargo fmt` check didn't pass. Please install fmt and clippy and check if it's formatted well and there're no clippy warnings before pushing changes. Thank you!
Hey, @HAaYAT0 Sure, that would be great! You can start from versionB from the post. You can reach out to me on discord - lmk if you need any help!
Another question - do we need to do changes in codehash.txt, as it's done [here](https://github.com/scroll-tech/zkevm-circuits/pull/1235/files#diff-af896e1754e274de6fb74de670a8c2bb1a2ffcae8ad01b716d09a9f69b5e0a15R9985-R10037) ? @ChihChengLiang
> We should add changes to codehash.txt. The content is the cached mapping of code hash to the corresponding bytecode. When we run the EIP1153 test, cached entries should be...
@ChihChengLiang I updated the tests submodule To reproduce the error: 1. `cd testool` 2. `cargo run --release --bin testool -- --suite EIP1153` or `cargo run --release --bin testool` It returns:...