Daniel M

Results 65 comments of Daniel M

This was done in 1.7.6 release: https://github.com/dsoftwareinc/fakeredis-py/releases

Warnings are fixed in the new version: https://github.com/dsoftwareinc/fakeredis-py/runs/6627979677?check_suite_focus=true

There is one warning that is relevant there: ``` test/test_aioredis2.py:59: PytestWarning: The test is marked with '@pytest.mark.asyncio' but it is not an async function. Please remove asyncio marker. If the...

@kloczek These warnings are equivalent to the behavior of redis-py: https://github.com/redis/redis-py/blob/3081a32b3852276999bb250655e4dfe2c87c654c/tests/test_commands.py#L2837-L2846

The package introduced support for django 4.1 but it was not published yet. Are there plans to publish a new version?

Hi, thanks for this. I think I will make it also into a guide in the contributing part in the readme. ### Implementing the command Creating a new command support...

Hi @the-wondersmith, thanks the initiative. Regarding JSON commands: I started breaking down all the commands to mixins under `command_mixins` directory. I think we would want to have it as a...

@the-wondersmith , `BZPOPMAX` is kind of similar, with a syntax of `BZPOPMAX key [key ...] timeout`. So you can use it as a reference: ``` @command((bytes, bytes), (bytes,), flags='s') def...

Wait with the type annotations. Keep in mind the library needs to support python 3.7+ (I think in python 3.7 you should use `import typing` - not sure when it...