Peter van Holland

Results 7 comments of Peter van Holland

I fixed this with: ``` diff --git a/src/routes/blog/containers/BlogContainer-spec.tsx b/src/routes/blog/containers/BlogContainer-spec.tsx index 0158f14..4815a06 100644 --- a/src/routes/blog/containers/BlogContainer-spec.tsx +++ b/src/routes/blog/containers/BlogContainer-spec.tsx @@ -6,7 +6,7 @@ import BlogContainer from './BlogContainer'; describe('BlogContainer', function() { it('works', function() {...

Hi - if you got this working could you share your solution? thanks!

It is kind of related, it is what happens if you manually link then try to build.

I have not used Next.js, but we are thinking of migrating our vanilla React app (currently in a Rush monorepo) to it and I cannot confirm from this issue if...

@Faithfinder can you please share your config setup to integrate knip with rush? Did you use a rush command? Did you have a single knip config file?

I am not sure, but this may be a fix, if possible through Cloudformation: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-restricting-access-to-lambda.html It seems the configuration for Lambda to allow public access to the function is not...

I am preparing a PR to fix this, though it might need some improvements