Nathan Shaaban

Results 82 comments of Nathan Shaaban

main is available to any and all contributions! No synchronization needed, happy to answer questions/point you in the right direction though. As for how to implement this, feature flag make...

If this is a breaking change anyways, we could expose BOTH ReconnectingClient and Client in the public interface

What's left to do here: - [x] expose reconnecting client as Client in external API (returned from `connect` function on the ClientBuilder) - [x] expose Client as RawClient (or something...

Code coverage is a staggering 88% (will be higher once https://github.com/1c3t3a/rust-socketio/issues/45 is fixed), is this still needed @1c3t3a ?

> @nshaaban-cPacket What alternatives to async callbacks would you consider? A possible alternative would be to somehow use the implementation of `Stream` to react to a packet and provide means...

Sorry it took so long to review, didn't see that you re-requested review. > fix tests so that it is ensured that callbacks are called correctly May want to remove...

> What alternatives to async callbacks would you consider? Another option is rather than sending the client in the callback, send an intermediary object that can uses a message channel...

0.3.0: - [x] Resolve relevant TODOs - [x] Be within +/- 20% performance of present main (see https://github.com/1c3t3a/rust-socketio/pull/71 ) - [x] Documentation - [x] remove warnings about &Socket callbacks (feature...

PRs welcome! [This line is where the engineio errors cause a panic](https://github.com/1c3t3a/rust-socketio/blob/9690c3c1fe47b813b1a588d5361dfd7c05df7432/socketio/src/socket.rs#L140).

@1c3t3a It would be easier to implement 0.4.0 if we used async internally, but didn't expose. That alright with you? Async internally but synchronous end-user interfaces? Using https://docs.rs/futures/0.3.17/futures/sink/index.html https://docs.rs/futures/0.3.17/futures/stream/index.html# internally,...