Clinton Graham

Results 16 comments of Clinton Graham

@seboettg , do you have any feedback on this?

Also, this transformation of mime type to genre: probably not robust enough for `GenreDAO`, but should we stub it out in that direction? https://github.com/pkp/texture/blob/bbac9e8e3300ab4aebfc12b096033d1a24bbf45c/TextureHandler.inc.php#L177-L199

Concrete example (if we want to keep it to the plugin): https://github.com/ulsdevteam/texture/commit/b461f23ec7a22f93d016a95031f3ba409271b603

@withanage , do you have any work so far on processing the DAR within PHP code? This was mentioned in the PKP Technical Committee particularly regarding the recent conversations across...

Start of work: https://github.com/scriptotek/php-alma-client/commit/39bd8e75b46220878709887343031efc5a19aa14

#17 implements updates for SMS numbers. We also anticipate submitting a PR for additions/updates for temporary addresses and updates to fines/fees. These will likely come over the next month.

@danmichaelo , #20 refactors updates for SMS numbers into general Contact Info updates.

This is a bug in the code. Specifically, `ArticleHandler::downloadSuppFile` expects that the `SubmissionFile` will have a 'old-supp-id' property accessible via `getData()`: https://github.com/pkp/ojs/blob/e8b8c0292b133d564a9ddd9f41905ea5d124e90c/pages/article/ArticleHandler.inc.php#L381 but, `SubmissionFile` was instantiated by `SubmissionFileService::getMany()`: https://github.com/pkp/ojs/blob/e8b8c0292b133d564a9ddd9f41905ea5d124e90c/pages/article/ArticleHandler.inc.php#L377 which...

N.b.: we plan to hotfix this temporarily in our instances by cloning `PKPSubmissionFileDAO::getByPubId()` to a `PKPSubmissionFileDAO::getBySetting()` and calling that from `ArticleFileHandler::downloadSuppFile()` until the full solution is spec'd, reviewed, and merged.