Cameron Mulhern
Cameron Mulhern
This PR adds the ability to blocklist Objective-C methods using --blocklist-item. The path format that's matched against is `ItemPath:: rustMethodName`. The Rust method name is used over the Objective-C name,...
Note: this is a different problem than #1341. When using crates_vendor in remote mode from the root workspace, incorrect labels are used in the `defs.bzl` and `crates.bzl` generated files. Here...
For example, this entry in Cargo.toml: ``` [dependencies.async_trait] package = "async-trait" version = "0.1.51" default_features = false features = [] ``` Will generate an alias such as: ``` alias( name...
`size` and `alignment` are considered "reserved words" for `Namer` purposes. See: https://github.com/google/flatbuffers/blob/205285c35c164c0368c913b3f611cf8d672bc103/src/idl_gen_rust.cpp#L134-L135 This is because these identifiers are used in the `flatbuffers::Push` trait. See: https://docs.rs/flatbuffers/latest/flatbuffers/trait.Push.html#provided-methods. Can we consider removing these...
The bzlmod extension appears to rely on `@cargo_bazel_bootstrap` directly, rather than relying on `CARGO_BAZEL_URLS` to skip bootstrapping, as the repository rule does. See: https://github.com/bazelbuild/rules_rust/blob/fe610dab73c3c61560a547bc661177dd5115fed7/crate_universe/private/module_extensions/cargo_bazel_bootstrap.bzl#L28 https://github.com/bazelbuild/rules_rust/blob/fe610dab73c3c61560a547bc661177dd5115fed7/crate_universe/private/crates_repository.bzl#L244-L249
The tag class definition for rust.host_tools includes `version`, but not `iso_date`. https://github.com/bazelbuild/rules_rust/blob/fe610dab73c3c61560a547bc661177dd5115fed7/rust/extensions.bzl#L126-L129 This leads to the following error when trying to use a nightly version of the rust host tools...
This allows compile_commands.json commands to work for users who use e.g. --experimental_convenience_symlinks. This also adds the ability to disable automatic workspace edits. While modifying the user’s workspace can help with...
### What happened? It seems like this is due to the dependency on aspect_rules_lint. As far as I can tell, this is only needed for development inside aspect_rules_lint. Can we...
The correct initialization order is ```Rust SimpleLogger::new() .with_level(log::LevelFilter::Info) .env() ``` Not ```Rust SimpleLogger::new() .env() .with_level(log::LevelFilter::Info) ``` Both SimpleLogger::env and SimpleLogger::with_level both override SimpleLogger::default_level. SimpleLogger::env should be called _after_ SimpleLogger::with_level, so...