Joseph Crosland

Results 62 comments of Joseph Crosland

Before: ![image](https://user-images.githubusercontent.com/1027041/194175969-a3fa3029-71f1-42d4-9c1a-095179624bc2.png) After: ![image](https://user-images.githubusercontent.com/1027041/194171579-53d68bd7-545e-4c63-b916-50ee5ac69f6c.png)

It'd probably be good to review the key and if it's potentially over-eagar

Figured I'd look at this while I have the whole dev env set up

let's wait for https://github.com/quay/clair/pull/1514 to be merged so we can do the same for the matcher

I suppose you could also wrap the err returned with `%w` ie. `fmt.Errorf("Error parsing version segment: %w", err)`, to allow to caller to discern why things failed. It's a weird...

Nice, this is definitely something we'd want. Is there not a way to do this directly in app-interface? The only thing I'd say about the PR itseld is; is there...

> @crozzy sorry for the bump - just checking if this PR has been overlooked? Sorry @frostmar it had indeed fallen through the cracks

Thanks for the updates, I think it seems like an improvement, @hdonnay is there a situation with clients where you could see this being a problem? @frostmar looks like you...