Carlos Quintana
Carlos Quintana
The change looks good, less code to mantain!
First of all, thanks for your fast response! I have checked and indeed it works as expected :+1: Last question regarding to this issue. I've been reading through the code...
Implemented in this PR :) https://github.com/davidcole1340/ext-php-rs/pull/139
@nicolas-grekas I've added it in a new public method annotated with `@afterClass`. If you prefer I can just annotate the `ensureKernelShutdown` method with `@afterClass`, but I found cleaner to split...
Made the change to set the annotation directly in the `ensureKernelShutdown` method.
@nicolas-grekas looks like by changing the method to `@afterClass` the Unit Tests check for 8.3 fails on ``` Symfony\Component\HttpClient\Tests\AmpHttpClientTest::testNonBlockingStream ``` Do you think it could be related to the test...
How should we proceed to include this, then? Will another PR be made for including the call to `ensureKernelShutdown`?
@nicolas-grekas there you go: https://github.com/symfony/symfony/pull/60693
Hi! ProtonPass developer here. We've identified the issue and we will try to fix it for the next release. Thanks for the report 👍 In the meantime, we've identified that...
Just as an update: Pass Android `1.26.2` is already available and should contain the fix 👍