Cory Harper

Results 13 comments of Cory Harper

Hi, thanks for looking to contribute to our package, a few things that cover multiple lines: This pull request's scope is too broad. The title indicates the changes made should...

@ShahriarKh are you sure this is coming from this package? A look at the [source code](https://github.com/sparksuite/react-accessible-dropdown-menu-hook/blob/master/src/use-dropdown-menu.ts) doesn't have any usage of that method. Its possible that the code is being...

Hi @uhoh-itsmaciek , thanks for using our package and being open to making contributions. For this contribution, it seems like your use-case can be covered by the [ReturnType](https://www.typescriptlang.org/docs/handbook/utility-types.html#returntypetype) utility type...

> Hi @uhoh-itsmaciek , thanks for using our package and being open to making contributions. For this contribution, it seems like your use-case can be covered by the [ReturnType](https://www.typescriptlang.org/docs/handbook/utility-types.html#returntypetype) utility...

Its not in your screenshot, but the following error message appears when you load the page: ``` Uncaught TypeError: _wrapNativeSuper__default.default is not a function at polished.js:317:55 at polished.js:4:78 at polished.js:5:3...

Seems like its related to [this line](https://github.com/styled-components/polished/blob/main/docs/assets/polished.js#L317) which was changed in [this commit](https://github.com/styled-components/polished/commit/a6c86998d5902a47f5ff231af9620dff9686bf9f#diff-102e758120672e55f341e8834cec02955c62ee97456468723787d57c0541f06eR363).

And as a last bit of information, this is what the object called out by the error looks like when the exception is encountered: ``` _wrapNativeSuper__default: default: undefined [[Prototype]]: Object...

@icambron Sorry for the tag, you're just the first maintainer I encountered. I'd be willing to contribute this change myself, but considering it's a change that as described would break...

I'm going to close this pull request, it's pretty stale, and the scope of the changes is too broad. It isn't clear that changes made here are needed or beneficial...

Right now I'm leaning towards the best design being to add an option `submenu: boolean = false`. When enabled two new controls would be added, which are detailed in the...