Stephen Elizabeth comments

Results 10 comments of


                                            Stephen Elizabeth

Don't call upstream if nothing found via friendly ID search

Hey sorry to disappear on this. What are you thinking here? Looks like the specs had some trouble getting started.

`exists?` returns false positives when query string begins with a number

@parndt were it up to me, I might argue that https://github.com/norman/friendly_id/blob/6a8b54ee3552553e0c3587caf92328af107cfd72/lib/friendly_id/finder_methods.rb#L31 should be changed to `false`, though that may have other consequences I'm not aware of. An alternative could be...

`exists?` returns false positives when query string begins with a number

@parndt if I'm not mistaken, that's what already happens. The problem stems from the fact that if the search for the friendly_id slug doesn't return anything, we then call `super`,...

Setting cache_options expiration without prefix causes prefix to default to nil instead of "geocoder:"

Sounds good to me--thanks for taking a look!

Fix Ruby 2.7 keyword arguments warnings

@gdelugre seems to have completely disappeared. It may be worth officially migrating to a fork of this gem

Safari : Invalid regular expression: invalid group specifier name (image-to-base64)

Fixed the issue in a fork if anyone is interested: https://github.com/corwinstephen/fixed-html-to-docx Two bad regexes, one in image-to-base64 and the other in `utils/url.js`. This switches to the fixed base64 package mentioned...

Collaboration not Competition!

Dope. Off the top of my head, seems like a good start would be to standardize event info and store as json instead of md. Tracking

import('axios-auth-refresh') wraped with default

Probably same issue: https://github.com/Flyrell/axios-auth-refresh/issues/284

`@user` is a scary default for `user.current`

Also got bit by this -- +1

Default import not working

Same