corentinravoux

Results 45 comments of corentinravoux

Yes this seems ok for me, I did not add or removed the unblind strategy. And the only conflict I saw was only on the addition of this option.

@Waelthus @iprafols I would like to have your opinion especially on the modifications of delta extraction on which I worked on. Since it does not only impact the P1D.

Yes we could separate the reading between 3D and 1D. However, I am wondering if the changes done on the 3D and 1D analysis at this stage might not be...

Sorry for the long time of this PR, but I did not forgot your comments @Waelthus ! I will first try to solve the DLA masking issue, and I will...

@Waelthus I checked your comment: I agree on the complex part, and I will implement the small changes you suggest. I am currently working (when I have time) on the...

This is a working version: the spectra are read independently for different exposure, the masks are applied to individual deltas, and the continuum fitting is performed on the coadd of...

Coverals is giving a failing check, @Waelthus @iprafols do you think this is because I should add a test for cross-exposure ?

Ok thanks! My plan to finish this PR which starts to be long: - Implement cross-exposure test (minimal or end-to-end) - Store the fft deltas in complex - Test on...

I implemented the coaddition of exposures before the delta extraction. After a test on Y1 data, and even with applying multprocessing, the coaddition of a large number of data take...

I changed my mind: I think we should try to avoid coadding with picca as much as possible. I will modify the cross-exposure so that the delta extraction is done...